Align Iris amplitude encoding benchmark between PennyLane and QDP#1088
Merged
ryankert01 merged 1 commit intoapache:mainfrom Feb 24, 2026
Merged
Align Iris amplitude encoding benchmark between PennyLane and QDP#1088ryankert01 merged 1 commit intoapache:mainfrom
ryankert01 merged 1 commit intoapache:mainfrom
Conversation
Contributor
Author
|
results in my local environment |
ryankert01
reviewed
Feb 24, 2026
| import torch | ||
|
|
||
|
|
||
| NUM_QUBITS = 2 |
Member
There was a problem hiding this comment.
Oh, It might be we want to keep the qubit small for a clear speedup result.
ryankert01
approved these changes
Feb 24, 2026
Member
ryankert01
left a comment
There was a problem hiding this comment.
lgtm, I think if we are going to add multiple dataset, we can abstract many things in common as a followup (not necessary) and utility to store results in a csv or something.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Changes
Why
Align the Iris amplitude encoding benchmark between the pure PennyLane baseline and the QDP pipeline so we can directly compare full training behavior with only the encoding step changed.
How
Updated pennylane_baseline/iris_amplitude.py and qdp_pipeline/iris_amplitude.py to share the same data loading, CLI options, and training loop, differing only in encoding (get_angles vs QDP QuantumDataLoader + StatePrep).
Added --data-file, optimizer/early-stop/trials flags, and consistent logging to both scripts to support reproducible comparisons.
please try it
Checklist