Add unified and configurable null handling#1101
Open
ryankert01 wants to merge 1 commit intoapache:mainfrom
Open
Add unified and configurable null handling#1101ryankert01 wants to merge 1 commit intoapache:mainfrom
ryankert01 wants to merge 1 commit intoapache:mainfrom
Conversation
309cff9 to
7fbc001
Compare
viiccwen
reviewed
Feb 28, 2026
Contributor
viiccwen
left a comment
There was a problem hiding this comment.
overall lg, but need to update docs, and left some comments.
| //! } | ||
| //! ``` | ||
|
|
||
| use arrow::array::{Array, Float64Array}; |
Contributor
There was a problem hiding this comment.
Array is not used in this file.
| /// Reads Float64 data from a Parquet file. | ||
| /// | ||
| /// Expects a single Float64 column. For zero-copy access, use [`read_parquet_to_arrow`]. | ||
| pub fn read_parquet<P: AsRef<Path>>(path: P) -> Result<Vec<f64>> { |
Contributor
There was a problem hiding this comment.
currently we specify read_* ( read_parquet(...) ) to use NullHandling::FillZero, should we adopt same strategy like *Readers (ParquetReader)?
like this?
pub fn read_parquet<P: AsRef<Path>>(path: P) -> Result<Vec<f64>>;
// to
pub fn read_parquet<P: AsRef<Path>>(
path: P,
null_handling: Option<NullHandling>,
) -> Result<Vec<f64>>;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Closes #765
Changes
Why
How
NullHandlingenum (FillZero|Reject)0.0while streaming mode threw a runtime error — both paths now use the samehandle_float64_nulls()helperFillZerofor backward compatibility;Rejectreturns a clear error with guidancePipelineConfig, PyO3 bindings, and the PythonQuantumDataLoaderbuilder (.null_handling("fill_zero" | "reject"))Checklist