Fix incorrect path of workspace in devcontainer setup.sh#1104
Fix incorrect path of workspace in devcontainer setup.sh#1104Howardisme wants to merge 2 commits intoapache:mainfrom
Conversation
|
|
||
| # setup pre-commit hooks | ||
| cd /workspaces/mahout | ||
| cd /workspace |
There was a problem hiding this comment.
Could you help me understand? I think it should be in mahout directory?
There was a problem hiding this comment.
Hi @ryankert01 and @viiccwen , Thank you for the quick response. I completely understand why it feels like it should be in mahout directly. However, I found devcontainer.json cause this error happened. In devcontainer.json, the workspace is explicitly mounted to /workspace:
Because devcontainer.json forces the target to /workspace, when setup.sh tries to run cd /workspaces/mahout on line 24, it throws the No such file or directory error and break the initialization of setup.
We have two ways to fix it:
- (My current PR): Update setup.sh to use cd /workspace to match the devcontainer.json. This is often safer because we don't know what the user names their local clone directory.
- Update devcontainer.json to mount to /workspaces/mahout instead.
Let me know which way you think is better to this issue or any follow up questions!
There was a problem hiding this comment.
Pls update ur own setting file.
There was a problem hiding this comment.
Got it! I wil update my local file to align with the script.
There was a problem hiding this comment.
Closing this PR. Looking forward to contributing to other parts of this project!
viiccwen
left a comment
viiccwen
left a comment
There was a problem hiding this comment.
Thx for contributing, but there is no need to change.
|
If u still have any issue in building the env, pls let us know. : ) |
3 participants
Related Issues
Fix #1103
Changes
Why
This PR fixes an issue where the DevContainer fails to initialize properly during a fresh build.
How
Modified
.devcontainer/setup.shline 24:cd /workspaces/mahout->cd /workspaceChecklist