MAHOUT-1802: Capture attached checkpoints (if cached) #185
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the optimizer generates checkpoints and attaches them to actual logical elements of the DAG via CheckpointAction$cp.
ie:
but, in:
drmD = drmC + drmE // computes drmA + drmB + drmC all overdrmCalready hascp1attached to it so we should assume the common computational path is the intent here regardless and should be used, instead of building plans that recompute it. That is,drmD = drmC + drmEshould implycp1 + drmEas well even if checkpoint is not used explicitly.This PR allows us to avoid excessive declarations like
and instead just use