MAHOUT-1638: implement String equivalent of Vec.makeCons()#99
Closed
avati wants to merge 1 commit into
Closed
Conversation
Necessary for creating an empty Vec to hold String labels in the future. Replace calls to Vec.makeCons with H2OHelper.makeEmptyStrVec() where the created Vec is used to store label strings. Also, fix an off-by-one bug in MapBlockHelper Signed-off-by: Anand Avati <avati@redhat.com>
Member
Contributor
|
This is superawesome. Thank you @avati ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Necessary for creating an empty Vec to hold String labels in the
future.
Replace calls to Vec.makeCons with H2OHelper.makeEmptyStrVec()
where the created Vec is used to store label strings.
Also, fix an off-by-one bug in MapBlockHelper
Signed-off-by: Anand Avati avati@redhat.com