fix(runtime): give sandbox boundary wait a time budget - #4387
Merged
Astro-Han merged 1 commit intoSep 2, 2026
Conversation
Poll waitForBoundaryRequest against a wall-clock deadline so loaded CI filesystem work can still emit sandbox_boundary_request before the helper gives up. Test-only; production runtime is unchanged. Fixes apache#4383 Generated-by: Cursor Co-authored-by: MarkGus0 <MarkGus0@users.noreply.github.com>
6 tasks
Astro-Han
approved these changes
Sep 1, 2026
Astro-Han
left a comment
Astro-Han
left a comment
Contributor
There was a problem hiding this comment.
Approving. The helper this reaches for already exists — waitFor in @maka/core/test-only/async-primitives — and the 5s / 10ms pair matches what shell-run-manager.test.ts already uses, so this is one fewer hand-rolled wait rather than one more. Strictly more patient than the 100 unbounded macrotask ticks it replaces, and the production runtime is untouched.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4383. Test-only: waitForBoundaryRequest now polls until a 5s wall-clock deadline instead of 100 macrotask ticks. Production runtime is unchanged. 15/15 sandbox-boundary tests passed locally. No behavior change.