feat(desktop): allow Side Conversations to select an independent model - #4499
Open
amaldevcm wants to merge 4 commits into
Open
feat(desktop): allow Side Conversations to select an independent model#4499amaldevcm wants to merge 4 commits into
amaldevcm wants to merge 4 commits into
Conversation
glm-5.3 (and others) were missing thinking-effort choices because an unrecognized modality value (upstream's new 'video') aborted the entire refresh instead of just that one model, so the committed snapshot never got updated. Filter unknown modality values per-model instead of rejecting the whole refresh, add a sanity floor to catch a degraded upstream response, and schedule a nightly refresh job that opens a PR for review. Addresses the snapshot-staleness root cause in apache#4398; the client-side catalog-authority and runtime-refresh changes remain separate work.
Side Conversations still inherit the source Session's model at fork time, but the Composer now exposes the normal model picker once the fork is committed, scoped to that companion Session only. Selecting a different model updates just the Side Conversation; changing the source Session's model no longer overwrites it. Model changes are rejected while a Turn is running and are retryable on failure, mirroring the existing setPermissionMode plumbing. Closes apache#4495
Astro-Han
requested changes
Sep 1, 2026
Astro-Han
left a comment
Astro-Han
left a comment
Contributor
There was a problem hiding this comment.
Thanks for picking this up, but I think we need to discuss if this feature is going to be implemented before doing it. btw It need a before after comparison.
…n-model-picker # Conflicts: # scripts/model-metadata/models-dev-api.snapshot.json # scripts/sync-model-metadata.mjs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implementation
SideChatSessionPort.setModel(session-id scoped) added and wired to the existingbridge.sessions.setModelIPC call.useQuoteCompaniongains asetModelaction mirroring the existingsetPermissionModepattern (turn-in-flight guard, pending state, non-destructive failure handling).QuoteCompanionPanelpassesactiveSession/modelChoices/onModelChange/modelSwitchAvailability/renderProviderMarktoComposeronce the companion fork exists, which flips the static read-only chip into the realChatModelSwitcher— the same component and props contract the main conversation already uses.renderProviderMarkthreaded end-to-end (app-shell.tsx→useWorkbarController→WorkbarHost→WorkbarSurface→QuoteCompanionPanel) for full visual parity with the main picker.Closes #4495
Test plan
tsc --noEmitclean on the renderer project for all touched files