ci(dependabot): label npm and actions updates with dependencies only - #4681
Conversation
Neither update block sets `labels`, so dependabot applies its defaults: `dependencies` plus a language label, `javascript` for npm and `github_actions` for github-actions. `javascript` appears only on dependabot PRs and nobody, human or workflow, reads it; the `github_actions` label does not even exist in the repository. Pin both blocks to `dependencies` alone. The configuration has to change before the `javascript` label is deleted, otherwise dependabot recreates it on its next update. Generated-by: Claude Code
jackwener
left a comment
There was a problem hiding this comment.
Approving at exact head cd4e68733a9647425ec45667bd6cff8e793e344d. No findings.
Four lines, and the claims behind them check out. Nothing in .github/workflows/ filters on javascript or github_actions, so no automation loses an input when dependabot stops applying them. dependencies already exists as a repository label, so the replacement set is not creating one on the fly. github_actions is indeed absent from the label list, which matches the description.
Setting labels replaces dependabot's defaults rather than adding to them, which is what makes the language label go away, and ignore, groups and the schedules are untouched.
The ordering in the description is right and worth keeping: the config has to land before anyone deletes the javascript label, or dependabot recreates it on the next update.
This is still marked as a draft, and the approval covers the review gate only — a draft cannot merge regardless.
Evidence boundary: dependabot's behaviour cannot be exercised locally, so the effect of the labels key rests on its documented schema, not on an observed run.
简体中文
在 cd4e68733a9647425ec45667bd6cff8e793e344d 上批准。没有发现。
四行改动,背后的主张我核过了。.github/workflows/ 里没有任何地方以 javascript 或 github_actions 作为筛选条件,所以 dependabot 不再打这些标签时,没有自动化会因此少掉输入。dependencies 已经是仓库里既有的标签,所以替换后的集合不会临时新建标签。github_actions 确实不在标签列表中,与描述一致。
设置 labels 是替换 dependabot 的默认值而不是追加,这正是语言标签消失的原因;ignore、groups 和调度都没有被动到。
描述里的先后顺序是对的,值得保留:必须先合配置,再删 javascript 标签,否则 dependabot 会在下一次更新时把它重新创建出来。
这个 PR 目前仍标记为草稿,本批准只覆盖审查门禁——草稿无论如何都无法合并。
证据边界:dependabot 的行为无法在本地验证,所以 labels 键的效果依据的是它的文档化 schema,而不是一次实际观测到的运行。
Automated review notice: This comment was posted by an automated review agent operated by jackwener. It is not an independent human review and does not replace one.
…pache#4681) Neither update block sets `labels`, so dependabot applies its defaults: `dependencies` plus a language label, `javascript` for npm and `github_actions` for github-actions. `javascript` appears only on dependabot PRs and nobody, human or workflow, reads it; the `github_actions` label does not even exist in the repository. Pin both blocks to `dependencies` alone. The configuration has to change before the `javascript` label is deleted, otherwise dependabot recreates it on its next update. Generated-by: Claude Code Generated-by: GLM-5.3-Flash (ZCode)
Summary
Dependabot applies its default labels to every update PR because neither block in
.github/dependabot.ymlsetslabels:dependenciesplus a language label,javascriptfor npm andgithub_actionsfor github-actions. Thejavascriptlabel exists only because of this default. It appears on dependabot PRs (36 PRs, 2 issues) and nothing else: no workflow filters on it and no maintainer uses it. Thegithub_actionslabel does not exist in the repository at all.This PR sets
labels: [dependencies]on both the npm and github-actions blocks so dependabot stops applying language labels.ignore,groupsand everything else are untouched.The config change has to land first: deleting the
javascriptlabel today would only get it recreated by dependabot on its next update.Follow-up after merge
javascriptlabel from the repository.Verification
npm run formatandnpm run lintrun clean (YAML is outside Biome's scope, so this only confirms no side effects).labelskey follows the documenteddependabot.ymlschema.AI use
Select exactly one:
Tool(s) and scope: Claude Code authored the entire change (config edit, commit message, PR description).
Checklist
Does this PR entail a change in behavior?