fix(ui): detail round 6 — one affordance one home (palette hints, skills CTA, runtime chip) - #649
Merged
Merged
Conversation
…lls CTA, runtime chip) - Command palette: shortcut hints (↵ 执行 / Esc 关闭) were duplicated — once as an input addon, once in the footer bar. The footer is the single source now; addon markup + CSS removed, contracts updated to pin the absence. - Skills 添加 CTA: was variant=ghost re-skinned by CSS into a hardcoded black-gradient pill (raw oklch literals that ignore theme palettes + off-family radius-pill). Now a real variant=default primary, same recipe as daily-review's 生成每日回顾 — one CTA form across module pages. - Skills runtime chip: 已启用/已停用 duplicated the adjacent Switch. Exception-only now — the chip renders solely for state_error; the enabled/disabled wording stays in the hover text.
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detail-audit round 6 — non-settings sweep (command palette, skills module page), lens: duplicated affordances + component re-skin overrides.
Findings & fixes
1. Command palette showed the same shortcut hints twice
The input row carried an inline-end addon (↵ 执行 / Esc 关闭) while the footer bar showed ↑↓ 选择 · ↵ 执行 · Esc 关闭 — both visible in the same viewport. The footer (the standard palette pattern, cf. VS Code/Raycast/Linear) is the single home now. Addon markup + its 4 CSS blocks removed; both pinning contracts updated to assert the absence instead.
2. Skills 添加 CTA was a ghost wearing fake primary chrome
.maka-skill-add-buttonre-skinnedvariant=ghostinto a black-gradient pill with rawoklch(0.19/0.32/1 0 0)literals — a theme leak (ignores palette tokens entirely, wrong in dark/brand themes) plusradius-pilloff the button radius family. This is exactly the component-re-skin antipattern from round 2 (killed .settingsInlineTextButton/.settingsBotAction). Now a genuinevariant=defaultprimary — the same recipe as daily-review's 生成每日回顾, so adjacent module pages share one CTA form.3. Skills runtime chip duplicated the Switch
Every row showed an 已启用 chip immediately next to an ON switch — two controls saying the same thing (exception-only lens). The chip now renders only for
state_error(状态异常), the one state the switch can't express; enabled/disabled wording remains in the row hover text. Deaddata-status=disabledCSS variant removed.Verification
module-skills+command-palette-openfixtures verify all three visually