ci: alignment auditor joins the pipeline — portable paths + fail-on-findings - #695
Merged
Conversation
…indings The CDP alignment auditor becomes a CI gate: hardcoded machine paths replaced (repo root derived from the script location, user-data dirs under os.tmpdir), findings and fixture launch errors now exit non-zero, and the e2e job runs it under the same xvfb pattern right after the renderer it builds. Locally verified: all fixtures clean, exit 0.
5 tasks
Astro-Han
added a commit
that referenced
this pull request
Jul 9, 2026
* fix(ci): resolve electron binary portably in alignment auditor #695 made the alignment auditor a CI gate but left the macOS Electron.app path hardcoded, so ubuntu-latest e2e dies with ENOENT before any fixture runs (breaks main and every open PR, including #680). Resolve via the electron package export like capture-screenshots and real-window-smoke, and fold spawn errors into the per-fixture failure count instead of an unhandled crash. * fix(ci): harden alignment auditor electron launch for Linux CI Portable electron path alone was not enough: every fixture still died with "fetch failed" on ubuntu-latest because the auditor launched unlike capture-screenshots / Playwright e2e (no cwd, switches after app path, stdio ignored, no Linux sandbox flags, fixed 8.5s sleep). Align spawn with the working launchers: cwd=apps/desktop, app='.', Chromium switches first, --no-sandbox/--disable-gpu/--disable-dev-shm-usage on Linux, pipe stderr/stdout, poll CDP until a page target appears, and include process tails in fixture errors so the next failure is diagnosable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the last governance-infrastructure item: scripts/audit-alignment.mjs (the round-13 machine auditor for same-type height mismatches / centerline drift / radius splits) is now a CI gate.
Locally verified end-to-end: all fixtures clean, exit 0.