Skip to content

Conversation

@HarshMehta112
Copy link

Fixes : #1275

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Your pull request should address just one issue, without pulling in other changes.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body.
    Note that commits might be squashed by a maintainer on merge.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
    This may not always be possible but is a best-practice.
  • Run mvn verify to make sure basic checks pass.
    A more thorough check will be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.


PrintWriter suppresses IOException by design. Instead of propagating errors, it silently captures them and sets an internal error flag. As a result, any I/O failure during write operations can go unnoticed unless checkError() is explicitly invoked.

While the usage of PrintWriter in DefaultMessageHolder is safe (since it writes to an in-memory StringWriter, which cannot throw IOException), its usage in AbstractLineAggregatingHandler is problematic because that class performs actual I/O operations. This could cause write failures to be ignored, leading to incomplete or lost log output without any visibility into the underlying issue.

✅ Solution

Replaced PrintWriter with BufferedWriter in AbstractLineAggregatingHandler so that I/O errors are surfaced immediately via thrown exceptions.

…eamWriter/BufferedWriter)

Signed-off-by: Harsh Mehta <harshmehta010102@gmail.com>
@slachiewicz slachiewicz added the bug Something isn't working label Dec 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stop using PrintWriter

2 participants