Fix swallowed I/O exceptions by replacing PrintWriter with (OutputStreamWriter/BufferedWriter) #1281
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes : #1275
Following this checklist to help us incorporate your
contribution quickly and easily:
Note that commits might be squashed by a maintainer on merge.
This may not always be possible but is a best-practice.
mvn verifyto make sure basic checks pass.A more thorough check will be performed on your pull request automatically.
mvn -Prun-its verify).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
PrintWritersuppressesIOExceptionby design. Instead of propagating errors, it silently captures them and sets an internal error flag. As a result, any I/O failure during write operations can go unnoticed unlesscheckError()is explicitly invoked.While the usage of PrintWriter in
DefaultMessageHolderis safe (since it writes to an in-memoryStringWriter, which cannot throwIOException), its usage inAbstractLineAggregatingHandleris problematic because that class performs actual I/O operations. This could cause write failures to be ignored, leading to incomplete or lost log output without any visibility into the underlying issue.✅ Solution
Replaced
PrintWriterwithBufferedWriterinAbstractLineAggregatingHandlerso that I/O errors are surfaced immediately via thrown exceptions.