[MASSEMBLY-958] Clarify dependency set resolution semantics - #1338
Merged
Conversation
elharo
reviewed
Aug 1, 2026
| <description> | ||
| A dependencySet allows inclusion and exclusion of project dependencies | ||
| in the assembly. | ||
| in the assembly. Dependency sets are evaluated against the project's |
Contributor
There was a problem hiding this comment.
Why would anybody think they did?
There was a problem hiding this comment.
Pull request overview
Clarifies Maven Assembly Plugin dependencySet documentation to reflect actual resolution behavior: dependency sets are filtered from the already conflict-resolved project dependency graph rather than being resolved as independent roots.
Changes:
- Updated the
DependencySetmodel description to state it is evaluated after Maven dependency conflict resolution. - Clarified that include patterns do not create separate dependency-resolution roots (applies to both assembly and assembly-component models).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/main/mdo/assembly.mdo | Updates DependencySet description to clarify post-conflict-resolution evaluation semantics. |
| src/main/mdo/assembly-component.mdo | Mirrors the same DependencySet documentation clarification for the component model to keep generated docs consistent. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
slawekjaranowski
approved these changes
Aug 3, 2026
|
@elharo Please assign appropriate label to PR according to the type of change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1163.
Summary
Clarify that dependency sets are evaluated against the project's dependency
graph after Maven dependency conflict resolution, and that include patterns do
not create separate dependency-resolution roots.
Motivation
The
useTransitiveDependenciesanduseTransitiveFilteringdescriptions canbe read as if the dependencies matching a dependency set's includes are
resolved as an independent graph. In practice, Maven first mediates the
assembly project's complete dependency graph. The Assembly Plugin then applies
dependency-set filters to the surviving artifacts and dependency trails.
As a result, a direct project dependency can supersede the same artifact
reached transitively through an included dependency. The surviving direct
artifact no longer has the included dependency in its trail and is not selected
through transitive filtering.
The clarification is added to both the assembly and assembly-component model
descriptions so their generated reference documentation remains consistent.
Validation
mvn -q verifyclarification.
Following this checklist to help us incorporate your
contribution quickly and easily:
Note that commits might be squashed by a maintainer on merge.
This may not always be possible but is a best-practice.
No runtime behavior changes; this pull request only updates generated model documentation.
mvn verifyto make sure basic checks pass.A more thorough check will be performed on your pull request automatically.
mvn -Prun-its verify).Integration tests were not rerun for this documentation-only change.
If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.