Fix #1349: complete the aggregation in the container descriptor handlers - #1350
Open
elharo wants to merge 1 commit into
Open
Fix #1349: complete the aggregation in the container descriptor handlers#1350elharo wants to merge 1 commit into
elharo wants to merge 1 commit into
Conversation
The FIXME comments in AbstractLineAggregatingHandler and ComponentsXmlArchiverFileFilter assumed the resource scan could be moved into plexus-archiver's AbstractArchiver, but the scan is required: the archiver runs its finalizers before scanning the added resources, so the file selectors are only applied while iterating. Document the actual behavior and add the missing resource scan to SimpleAggregatingDescriptorHandler, whose aggregated file was previously empty.
elharo
marked this pull request as ready for review
August 5, 2026 11:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The FIXME comments in AbstractLineAggregatingHandler and ComponentsXmlArchiverFileFilter assumed the resource scan could be moved into plexus-archiver's AbstractArchiver, but the scan is required: the archiver runs its finalizers before scanning the added resources, so the file selectors are only applied while iterating. Document the actual behavior and add the missing resource scan to
SimpleAggregatingDescriptorHandler, whose aggregated file was previously empty.
fixes #1349