Account for non-test transitive dependency scopes - #294
Open
wilx wants to merge 1 commit into
Open
Conversation
Build separate compile and runtime dependency graphs when identifying test-only dependencies. This avoids suggesting test scope when another non-test dependency still requires the candidate transitively. Fixes apache/maven-dependency-plugin#1483
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Avoid recommending
testscope for a direct dependency when the same artifactis still required transitively on the compile or runtime dependency graph.
The analyzer now builds separate compile and runtime graphs without the direct
test-only candidates and suppresses the warning for candidates that remain
reachable. This prevents an unsafe scope change: Maven conflict mediation can
otherwise hide the required transitive artifact behind the direct test-scoped
declaration.
Fixes #295
Validation
mvn -Prun-its verifymvn clean -Prun-its verifyInvoker projects passed. The remaining project asserts the previous scope
recommendation and passes with the unpatched analyzer. Its dependency graph
contains the exact condition fixed here: JUnit is also reachable through
maven-project -> plexus-container-default.Following this checklist to help us incorporate your
contribution quickly and easily:
Note that commits might be squashed by a maintainer on merge.
This may not always be possible but is a best-practice.
mvn verifyto make sure basic checks pass.A more thorough check will be performed on your pull request automatically.
mvn -Prun-its verify).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.