Conversation
There was a problem hiding this comment.
Pull request overview
This PR adjusts UnpackUtil.logUnpack() logging so the “Unpacking …” message is no longer emitted at INFO level (addressing the inverted/incorrect logging behavior described in #1618) and is intended to only appear when debug logging is enabled.
Changes:
- Reworked
logUnpack()to gate message construction onisDebugEnabled(). - Intended to move the unpack log message from INFO to DEBUG to reduce log noise.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+159
to
183
| if (logger.isDebugEnabled()) { | ||
| StringBuilder msg = new StringBuilder(); | ||
| msg.append("Unpacking "); | ||
| msg.append(file); | ||
| msg.append(" to "); | ||
| msg.append(location); | ||
|
|
||
| if (includes != null && excludes != null) { | ||
| msg.append(" with includes \""); | ||
| msg.append(includes); | ||
| msg.append("\" and excludes \""); | ||
| msg.append(excludes); | ||
| msg.append("\""); | ||
| } else if (includes != null) { | ||
| msg.append(" with includes \""); | ||
| msg.append(includes); | ||
| msg.append("\""); | ||
| } else if (excludes != null) { | ||
| msg.append(" with excludes \""); | ||
| msg.append(excludes); | ||
| msg.append("\""); | ||
| } | ||
|
|
||
| StringBuilder msg = new StringBuilder(); | ||
| msg.append("Unpacking "); | ||
| msg.append(file); | ||
| msg.append(" to "); | ||
| msg.append(location); | ||
|
|
||
| if (includes != null && excludes != null) { | ||
| msg.append(" with includes \""); | ||
| msg.append(includes); | ||
| msg.append("\" and excludes \""); | ||
| msg.append(excludes); | ||
| msg.append("\""); | ||
| } else if (includes != null) { | ||
| msg.append(" with includes \""); | ||
| msg.append(includes); | ||
| msg.append("\""); | ||
| } else if (excludes != null) { | ||
| msg.append(" with excludes \""); | ||
| msg.append(excludes); | ||
| msg.append("\""); | ||
| logger.debug(msg.toString()); | ||
| } |
Member
|
Simillary here title of PR not describe what we do .... |
Member
|
also labels is used to categorize PR in release notes |
Contributor
Author
|
done |
slawekjaranowski
approved these changes
May 17, 2026
|
@elharo Please assign appropriate label to PR according to the type of change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've been logging this when info logs are not enabled and not logging it when they are. Either way, these logs are noisy so set this to to log at debug level.
fixes #1618