remove todos and other IDE inserted boilerplate #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| testDir = null; | ||
| } | ||
|
|
||
| stubFactory = null; |
Contributor
There was a problem hiding this comment.
- Why did we ever need to mark the stubFactory null, isn't garbage collection smart enough to deal with an object like this?
- If not, why do we not need to manually mark stubFactory as null anymore?
ian-lavallee
approved these changes
Jun 30, 2020
cosmin
pushed a commit
to cosmin/maven-dependency-plugin
that referenced
this pull request
Nov 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ian-lavallee