Skip to content

remove todos and other IDE inserted boilerplate #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2020
Merged

remove todos and other IDE inserted boilerplate #61

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions src/test/java/org/apache/maven/plugins/dependency/AbstractDependencyMojoTestCase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,6 @@ public abstract class AbstractDependencyMojoTestCase

protected DependencyArtifactStubFactory stubFactory;

public AbstractDependencyMojoTestCase()
{
super();
}

protected void setUp( String testDirStr, boolean createFiles )
throws Exception
{
Expand Down Expand Up @@ -69,16 +64,11 @@ protected void tearDown()
}
catch ( IOException e )
{
// TODO Auto-generated catch block
e.printStackTrace();
fail( "Trying to remove directory:" + testDir + System.lineSeparator() + e.toString() );
}
assertFalse( testDir.exists() );

testDir = null;
}

stubFactory = null;
Copy link
Contributor

@ian-lavallee ian-lavallee Jun 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Why did we ever need to mark the stubFactory null, isn't garbage collection smart enough to deal with an object like this?
  2. If not, why do we not need to manually mark stubFactory as null anymore?

}

protected void copyFile( AbstractDependencyMojo mojo, File artifact, File destFile )
Expand Down
1 change: 0 additions & 1 deletion ...ava/org/apache/maven/plugins/dependency/testUtils/stubs/StubDefaultFileMarkerHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ public class StubDefaultFileMarkerHandler
public StubDefaultFileMarkerHandler( Artifact artifact, File markerFilesDirectory )
{
super( artifact, markerFilesDirectory );
// TODO Auto-generated constructor stub
}

protected File getMarkerFile()
Expand Down
7 changes: 0 additions & 7 deletions src/test/java/org/apache/maven/plugins/dependency/testUtils/stubs/StubMarkerFile.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,33 +27,26 @@ public class StubMarkerFile
extends File
{

/**
*
*/
private static final long serialVersionUID = 1L;

public StubMarkerFile( String pathname )
{
super( pathname );
// TODO Auto-generated constructor stub
}

public StubMarkerFile( URI uri )
{
super( uri );
// TODO Auto-generated constructor stub
}

public StubMarkerFile( File parent, String child )
{
super( parent, child );
// TODO Auto-generated constructor stub
}

public StubMarkerFile( String parent, String child )
{
super( parent, child );
// TODO Auto-generated constructor stub
}

public boolean createNewFile()
Expand Down
1 change: 0 additions & 1 deletion ...ava/org/apache/maven/plugins/dependency/testUtils/stubs/StubSourcesFileMarkerHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ public class StubSourcesFileMarkerHandler
public StubSourcesFileMarkerHandler( Artifact artifact, File markerFilesDirectory, boolean resolved )
{
super( artifact, markerFilesDirectory, resolved );
// TODO Auto-generated constructor stub
}

protected File getMarkerFile( boolean res )
Expand Down