Skip to content

Conversation

@andretadeu
Copy link
Contributor

According to the issue MDEP-586, it is not possible to unpack different files from the same JAR file in N distinct folders. In this pull request, I used the configuration parameter markersDirectory to setup folders containing the dependencies marked for each directory. The dependencies will only be marked at each execution of unpack-dependencies goal in their respective folder, so one execution will not dirty the folder of another execution.

In my view, I do not think this is a bug.

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MDEP-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MDEP-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@rfscholte
Copy link
Contributor

ResourceArtifact-1.0.jar/ResourceArtifact-1.0.pom this is the problem: pom needs to be next to the jar-directory, not inside.

@andretadeu
Copy link
Contributor Author

@rfscholte Done.

@rfscholte
Copy link
Contributor

Jenkins at ASF is happy too. If you remove the return from verify.groovy, add yourself as contributor to the pom (if desired) and squash the commits, I'll merge this PR.

… the same artifact do work. (#1)

* [MDEP-586] Unpacking different resources into different location from the same artifact do work. 

- Create src/it/mdep-586-unpacking-resources.
- Setup ResourceArtifact-1.0.jar as a mock JAR to be dealt with mrm-maven-plugin.
- Upgrade mrm-maven-plugin to version 1.2.0.
@rfscholte rfscholte merged commit 9bcd5f2 into apache:master Jan 13, 2019
@andretadeu andretadeu deleted the MDEP-586 branch January 19, 2019 00:23
asfgit pushed a commit that referenced this pull request Sep 29, 2021
…phrase is not given (#9)

* [MGPG-79] fix handling of external pinentry programs in case the passphrase is not given.
@jira-importer
Copy link

Resolve #1019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants