[MDEPLOY-279] Better validation for alt deploy repository mojo parameter #12
Conversation
michael-o
left a comment
michael-o
left a comment
There was a problem hiding this comment.
While this looks sound, should we rather switch to non-greedy matches should could have avoided this from the start? See my comment in JIRA.
|
I literally copy+pasted m-d-p regexp from 2.x to be 100% sure it is what it is (to match exactly what 2.x did match). Also, IMHO this IF-ELSE clearly explains what and why happens. Is redundant, but buys it out at clarity IMO. |
|
OK, let me think about this. If we can make it even more idiotproof then we should do it. |
Do not accept anything but expected format. Fail always if not expected alt repo string passed in, but improve error messages best possible. IF legacy used, provide useful error message giving solution as well.
cstamas
force-pushed
the
MDEPLOY-279-validation
branch
from
0d78f76 to
578d82f
Compare
|
Thanks, will look into new changes. |
|
Going through now... |
michael-o
left a comment
michael-o
left a comment
There was a problem hiding this comment.
I have pushed two small changes and left a few open issue, but I general I like the approach.
Extend tests as well.
|
Looks good to me now, I will run tests again! |
|
Thanks for bearing with me... |
|
Resolve #549 |
5 participants
Do accept proper format ONLY, for legacy provide "solution" and
fail with meaningful error message.
https://issues.apache.org/jira/browse/MDEPLOY-279