[MENFORCER-314] - Warn if EnforcerRuleException has no message#43
[MENFORCER-314] - Warn if EnforcerRuleException has no message#43famod wants to merge 1 commit intoapache:masterfrom
Conversation
|
@famod I prefer this one. I will be happy to merge as soon as we have the test. cc @khmarbaise |
|
@eolivelli I had a quick look at the existing integration tests and I have to say that I have no clue how to test this very specific (and rare) case with capabilities of maven-invoker-plugin. Extending |
This should help to find out why DependencyConvergence sometimes fails without providing a message.
|
I jumped ahead and extended Please note that I won't be able to put much more effort into this entire issue as I am busy elsewhere. PS: Yes, I did see that there is a custom |
|
@famod great work. Will commit soon |
|
committed as 9bf2bac thank you ! |
|
You are welcome and thank you, too! |
|
Resolve #794 |
1 similar comment
|
Resolve #794 |
Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[MENFORCER-XXX] - Fixes bug in ApproximateQuantiles,where you replace
MENFORCER-XXXwith the appropriate JIRA issue. Best practiceis to use the JIRA issue title in the pull request title and in the first line of the
commit message.
mvn clean verifyto make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.