Add ResourceHandler implementations#47
Closed
sixcorners wants to merge 5 commits intoapache:masterfrom
sixcorners:add-resource-handler-implementations
Closed
Add ResourceHandler implementations#47sixcorners wants to merge 5 commits intoapache:masterfrom sixcorners:add-resource-handler-implementations
sixcorners wants to merge 5 commits intoapache:masterfrom
sixcorners:add-resource-handler-implementations
Conversation
Contributor
sixcorners
commented
Feb 2, 2020
sixcorners
commented
- What do you all use to format this code?
- I need to add unit tests to these but before that I want to ask:
- Do you all think it would be a good idea if the library provided some ready to use implementations of ResourceHandlers?
Member
|
Thank you for proposal. Could you create Jira task for this improvement? |
Contributor
Author
Contributor
Author
|
Added "throws IOException" back to the empty close methods. |
Contributor
Author
|
Removed the thing where I made the overridden methods return the more specific type using co-variant return types. Returning BufferedReader or BufferedInputStream doesn't really help people using the API a lot but it does lock in the implementation that has to be returned. |
Contributor
Author
|
Is there a way to put a work in progress tag on this? |
Member
|
Obsoleted by #199 |
cstamas
added a commit
that referenced
this pull request
Apr 23, 2022
Add OOTB resource handler implementations to index reader. Original PR #47 Co-authored-by: sixcorners <sixcorners@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.