Skip to content

Conversation

@Bukama
Copy link
Contributor

@Bukama Bukama commented Dec 28, 2025

Add another JDK to the matrix to check JEP 493 changes

Add another JDK to the matrix to check JEP 493 changes
Add another JDK to the matrix to check JEP 493 changes
Copy link
Contributor

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very helpful. Thanks. I do think we need to figure out how to fix this before merging.

Copy link
Contributor

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also consider adding at least temurin 25 and maybe zulu to other projects' CI configs since there does seem to be the real possibility of code working on Oracle but not temurin.

@Bukama
Copy link
Contributor Author

Bukama commented Dec 28, 2025

We should also consider adding at least temurin 25 and maybe zulu to other projects' CI configs since there does seem to be the real possibility of code working on Oracle but not temurin.

zulu (by Microsoft and Azul, not Oracle) is the default JDK we built on (see https://github.com/apache/maven-gh-actions-shared/blob/417fdff72db17fcbafd5f8d2471360e9b39f4ae3/.github/workflows/maven-verify.yml#L44 ). There are a few projects (e.g. mnaven javadoc plugin or this PR) where we overwrite this to use other/additional JDK.

However it seems that Zulu JDK still ships with JMOD folder, even that they "support the concept of JEP 493" (https://docs.azul.com/core/release/july-2025/release-notes) as the build pipeline of the Maven JMod Plugin shows. Temurin JDK folks wrote that they follow the OpenJDK and removed the JMOD files, so they seem to be "closer" to the original/base Open JDK. So yes I agree we should add Temurin to general Mavens GHA

edit: Opened a PR there

@Bukama
Copy link
Contributor Author

Bukama commented Dec 28, 2025

This is very helpful. Thanks. I do think we need to figure out how to fix this before merging.

ofc. That's why it's only a draft. I wanted to verify the different outcome of Temurin on GHA too (not only on my local machine)

@slachiewicz
Copy link
Member

Please avoid adding too many java flavors as this would be unnecessary multiplying no execution - for each java &Maven version. Let's be a bit more green to the environment and donated hardware resources

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants