[MSHARED-346] missing properties usually set by m-site-p (outputEncoding, ...)

[jira-importer]

Hervé Boutemy opened MSHARED-346 and commented

see http://maven.apache.org/doxia/doxia-sitetools/doxia-site-renderer/

When doxia-site-renderer is used by maven-site-plugin, the following template properties are defined:

when reports are invoked directly as goals, without m-site-p, these properties are not set

this leads to wrong HTML like reported in MCHECKSTYLE-126 because outputEncoding is not defined, for example

---

Affects: maven-reporting-impl-2.2

Issue Links:

• MSHARED-348 support reporting encoding configuration when used as goal
  ("is superceded by")
• MCHECKSTYLE-126 Generated HTML page contains "charset=${outputEncoding}"
  ("is depended upon by")

[jira-importer]

Hervé Boutemy commented

done in r1623568

[jira-importer]

Michael Osipov commented

I have to reopen this one because I do not like the commit. You have set UTF-8 by default and completely ignored the properties for that. If take a good look at this, your code should resemble.

[jira-importer]

Hervé Boutemy commented

wrong
or more precisely: in this comit, this is done exactly as done previously = UTF-8
just fixing the fact that the encoding was not defined as property

see MSHARED-348 for the enhancement you expect

[jira-importer]

Michael Osipov commented

The subsequent ticket does its job. Thank you!