[MSHARED-159] remove [WARNING] Deprecated API called - not org.apache.maven.doxia.sink.Sink instance and no SinkFactory available. Please update this plugin.

[jira-importer]

Hervé Boutemy opened MSHARED-159 and commented

First: this message is not very informative: maven-site-plugin should be updated, not the report causing the warning (like seen in MPIR-194)

Second: maven-site-plugin is in cause, not really maven-reporting-impl: see MSITE-490

---

Affects: maven-reporting-impl-2.1

Issue Links:

• MSITE-490 [WARNING] Deprecated API called - not org.apache.maven.doxia.sink.Sink instance and no SinkFactory available. Please update this plugin.

• MPDF-46 Remove [WARNING] Deprecated API called

• MPIR-194 [WARNING] Deprecated API called
  ("is depended upon by")

[jira-importer]

Hervé Boutemy commented

done in r960042

[jira-importer]

Dennis Lundberg commented

Shouldn't this warning still be in the reporting implementation, even if maven-site-plugin is fixed?
Isn't it still possible for a reporting plugin to call

generate( org.codehaus.doxia.sink.Sink aSink, Locale aLocale )

If that is possible then we should issue a warning so that we finally, some day, can get rid of org.codehaus.doxia.sink.Sink.

[jira-importer]

Hervé Boutemy commented

generate method is either called by maven-site-plugin, either called by another plugin that wants to generate report independently from maven-site-plugin

which plugin other than maven-site-plugin generates reports?

the only case I know of is the plugin itself, to be able to invoke the standalone report without whole site: this case is implemented in reporting implementation, with a call to the MavenMutiPageReport API

I don't find any practical cases needing this warning.
On the other hand, I know that maven-site-plugin < 3.0-beta-1 can't call the new API because of classloading issues (MavenPultiPageReport interface is not in Maven core classloader, but loaded separately for every reporting plugin)

Then this warning has only drawbacks to IMHO