Skip to content

[MRESOLVER-238] Create shaded transport-http#149

Closed
cstamas wants to merge 1 commit into
masterfrom
MRESOLVER-238-shaded-transport-http
Closed

[MRESOLVER-238] Create shaded transport-http#149
cstamas wants to merge 1 commit into
masterfrom
MRESOLVER-238-shaded-transport-http

Conversation

@cstamas

@cstamas cstamas commented Feb 1, 2022

Copy link
Copy Markdown
Member

That looks very same to that of wagon-http.


https://issues.apache.org/jira/browse/MRESOLVER-238

@cstamas cstamas requested a review from michael-o February 1, 2022 13:40
@cstamas

cstamas commented Feb 1, 2022

Copy link
Copy Markdown
Member Author

Am really unsure do we want this. Originally wagon-http had shaded in http-client to not pollute plugins classpath. But this -- in case of transport-http -- would also prevent extension/addition of ChecksumExtractor as it uses http-client classes...

Hence, as "pollution" issue will be gone with maven-core-api, I think this can wait...

@cstamas cstamas marked this pull request as draft February 1, 2022 14:01
@cstamas

cstamas commented Feb 1, 2022

Copy link
Copy Markdown
Member Author

Nope, not doing this.

@cstamas cstamas closed this Feb 1, 2022
@cstamas cstamas deleted the MRESOLVER-238-shaded-transport-http branch February 1, 2022 14:07
@michael-o

Copy link
Copy Markdown
Member

50 Shades of Resolver...

@jira-importer

Copy link
Copy Markdown

Resolve #1411

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants