[MSHARED-442] Remove shading of artifact instead of using simple jar

[jira-importer]

Karl Heinz Marbaise opened MSHARED-442 and commented

Currently the maven-shared-utils are being shaded during the build but why do we need that? It would be simpler to use create a simple jar file instead. The old build included commons-io into the shaded jar. commons-io dependency is defined optional.

---

Affects: maven-shared-utils-0.9

Issue Links:

• MSHARED-444 Make the optional dependency (commons-io) to a usual dependency
  ("is depended upon by")

[jira-importer]

Karl Heinz Marbaise commented

Fixed in r1706708 4b5bd90

[jira-importer]

Karl Heinz Marbaise commented

Followup r1706721

[jira-importer]

Kristian Rosenvold commented

I'm not sure this is a good idea, but I'll let this blow up somewhere before reverting :)

[jira-importer]

Hervé Boutemy commented

sorry, I did not hav time to look at this before
I don't think this is a good idea either: commons-io as optional just will make the util blow up if someone uses the class(es) that was(were) previously shaded

What is the problem you're trying to solve by removing shade?
rat failure?

[jira-importer]

Karl Heinz Marbaise commented

The question is why do we shade dependencies instead of using simple the dependency mechanism? Apart from that using shaded classes could produce class loading issues. So best would be to change the optional into a usual dependency which might be a better solution..?

[jira-importer]

Hervé Boutemy commented

AFAIK, the idea was just to have a plexus-utils replacement, then simple lib without dependencies, without recoding code that was already perfectly coded in existing libs