[MSHARED-971] System environment variable are always added to maven-invoker

[jira-importer]

Slawomir Jaranowski opened MSHARED-971 and commented

In org.apache.maven.shared.invoker.MavenCommandLineBuilder

https://github.com/apache/maven-invoker/blob/d58703dd592ba0bc6f0a09928d0cce90e4002af9/src/main/java/org/apache/maven/shared/invoker/MavenCommandLineBuilder.java#L197-L242

we have code:

        if ( request.isShellEnvironmentInherited() )
        {
                cli.addSystemEnvironment();
         }

but in org.apache.maven.shared.utils.cli.Commandline we have:

public String[] getEnvironmentVariables()
   {
       addSystemEnvironment();
      ...
    }

System environment variable are always added - it is inconsistent implementation.

---

Issue Links:

• MSHARED-1014 Optionally inherit system environment variables by Commandline
  ("is blocked by")
• MSHARED-969 Environment variable with null value

Remote Links:

• GitHub Pull Request #79
  

0 votes, 7 watchers

[jira-importer]

Sylwester Lachiewicz commented

/**
 * Indicates whether the environment variables of the current process should be propagated to the Maven invocation.
 * By default, the current environment variables are inherited by the new Maven invocation.
 * 
 * @return <code>true</code> if the environment variables should be propagated, <code>false</code> otherwise.
 */
boolean isShellEnvironmentInherited();

so by default it should be inherited, but You have option to disable it if needed

[jira-importer]

Slawomir Jaranowski commented

This option is not respected as I show in description.
addSystemEnvironment is always called

[jira-importer]

Martin Kanters commented

I would agree with Slawomir Jaranowski . What do you think Sylwester Lachiewicz?

[jira-importer]

Sylwester Lachiewicz commented

I'm also ok

[jira-importer]

Slawomir Jaranowski commented

What proposition for resolve?.

I think options isShellEnvironmentInherited should be respected ... but we don't know how impact will can be.

Some code can depends on bug in implementation without awareness.

[jira-importer]

Robert Scholte commented

To me this is not a bug in maven-shared-utils. Instead the bug would be in maven-invoker, saying value of isShellEnvironmentInherited() has no effect (it requires a unittest to proof so).
To fix it, it will require an improvement in Commandline.

[jira-importer]

Matthias Bünger commented

This project has moved from Jira to GitHub Issues. This issue was migrated to apache/maven-invoker#133.