Update PlantUML Maven Plugin and drop requirement for dot#700
Closed
mthmulders wants to merge 3 commits intoapache:masterfrom
Closed
Update PlantUML Maven Plugin and drop requirement for dot#700mthmulders wants to merge 3 commits intoapache:masterfrom
mthmulders wants to merge 3 commits intoapache:masterfrom
Conversation
slawekjaranowski
approved these changes
Feb 22, 2025
Bukama
approved these changes
Feb 22, 2025
kwin
reviewed
Feb 22, 2025
|
|
||
| legend | ||
| {{ | ||
| !pragma layout smetana |
Member
There was a problem hiding this comment.
any reason this is not affected by the global pragma?
Contributor
Author
There was a problem hiding this comment.
No clue. Trial and error showed me that the nested diagram needs this separately. Also happened when I had the diagram open in VS Code, so it seems to me it's not a Maven plugin issue.
slachiewicz
approved these changes
Feb 22, 2025
kwin
approved these changes
Feb 22, 2025
Contributor
Author
|
Closed in 10d086a. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following this checklist to help us incorporate your
contribution quickly and easily:
Note that commits might be squashed by a maintainer on merge.
mvn siteand examine output intarget/sitedirectory.Site will also be built on your pull request automatically and attached to GitHub Action result.
If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
Closes #630.