Fork test-jar to generate-test-sources

[kratos0718]

Fixes #304

Problem

TestSourceJarMojo packages test sources, but forks only to generate-sources:

@Mojo(name = "test-jar", defaultPhase = "package")
@Execute(phase = "generate-sources")

Test sources contributed by another plugin bound to generate-test-sources do not exist yet when the mojo runs, so they are missing from the test-sources jar. TestSourceGeneratedJarMojo packages the same content and already forks to generate-test-sources.

Fix

Fork to generate-test-sources. It comes later in the default lifecycle, so everything the previous fork covered is still covered — the change only widens the forked build.

Testing

The test-jar IT only generated sources in generate-sources, so it passed either way and did not pin the fork phase. It now also has a generate-test-sources execution and asserts that its output reaches the jar, mirroring what the test-jar-generated IT already does for generated-test-jar.

Against the current generate-sources fork the extended IT fails on exactly that entry, with the rest of the jar intact:

Checking for existence of META-INF/MANIFEST.MF
Checking for existence of MyTest.java
Checking for existence of test.properties
Checking for existence of generated.properties
Checking for existence of generate-test-sources.properties
FAILURE!

The build plan shows the cause — the forked build stops before the new execution:

--- init fork of ...:test-jar for ...:test-jar (default-cli) ---
Goal: maven-antrun-plugin:1.3:run (generated-sources)
--- exit fork ---

With the fix, test-jar, test-jar-generated, test-jar-no-fork and test-jar-classifier all pass, along with the 10 unit tests. Run on Maven 4.0.0-beta-3.

• I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004

[kratos0718]

Closing — #316 was already open for this and I missed it before starting. Apologies for the duplicate noise.

For whatever it is worth, the one thing here that is not in #316 is that the existing test-jar IT passes either way today, since it only generates sources in generate-sources. #316 adds a separate test-jar-generate-test-sources IT, which covers the fix; extending the existing one as well would also stop it silently agreeing with a future regression. Entirely your call whether that is worth a follow-up.