Faster queue#306
Closed
Tibor17 wants to merge 5 commits into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It requires some talk beforehand. The improvements done in
ThreadedStreamConsumerare using the packagejava.util.concurrent.lockswhich makes it however working but not easy to understand. Since all there Java Locks are built using the superclassAbstractQueuedSynchronizerin Java we can utilize this class and create our own helper with synchronization stuff and there isQueueSynchronizerfor such a reason. Very straightforward. The threads T1 and T2 have some rules. These threads are always two instances. The T1 drains the queue and T2 feeds the events to the queue.The rules for concurrency are:
T1 is waiting while the queue is empty
If T2 has reached the QUEUE_MAX_ITEMS, the thread is disabled for scheduling and waiting for the notification from T1
T2 resumes after T1 has drained the queue