Fix env property example in JDK discovery docs#186
Open
elharo wants to merge 1 commit into
Open
Conversation
The example for selecting a toolchain by environment variable used <toolchain.jdk.version>JAVA17_HOME</toolchain.jdk.version> but this should be <toolchain.jdk.env>. Also fix the malformed XML closing tag.
There was a problem hiding this comment.
Pull request overview
Updates the JDK discovery documentation examples to correctly demonstrate selecting a toolchain via an environment variable, aligning the documented property name with the plugin’s actual parameter.
Changes:
- Fixes the example property name from
toolchain.jdk.versiontotoolchain.jdk.envfor env-var based selection. - Fixes a malformed XML closing tag in the env-var example snippet.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
98
to
+101
| +---+ | ||
| <properties> | ||
| <toolchain.jdk.version>JAVA17_HOME</toolchain.jdk.version> | ||
| <properties> | ||
| <toolchain.jdk.env>JAVA17_HOME</toolchain.jdk.env> | ||
| </properties> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The example for selecting a toolchain by environment variable incorrectly used
<toolchain.jdk.version>instead of<toolchain.jdk.env>. Also fixes malformed XML closing tag.