[MWAR-220] Add integration test for overlay dependencyManagement version conflict#638
Closed
elharo wants to merge 4 commits into
Closed
[MWAR-220] Add integration test for overlay dependencyManagement version conflict#638elharo wants to merge 4 commits into
elharo wants to merge 4 commits into
Conversation
elharo
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integration test for MWAR-220 / issue #389
Adds an integration test that reproduces the issue where dependencyManagement does not filter conflicting dependency versions pulled in by WAR overlays.
Test setup
overlay-wardepends onplexus-utils:3.0.24main-warhas dependencyManagement pinningplexus-utilsto @plexusUtilVersion@ (4.0.3) and usesoverlay-waras an overlayExpected result (current)
Both
plexus-utils-3.0.24.jar(from overlay unpacking) andplexus-utils-4.0.3.jar(from dependencyManagement) appear in the final WAR'sWEB-INF/lib.Desired behavior
Only the dependencyManagement-pinned version (
plexus-utils-4.0.3.jar) should appear.This test is expected to fail on CI — it documents the known issue. A subsequent fix should make it pass.