Fix #12085: regression tests for version inheritance from remote parent#12090
Merged
Conversation
…parent The issue reported a null root artifact error when building projects that inherit version from a remote parent POM. Investigation showed the actual cause was uninterpolated repository expressions leaking through to the CollectRequest validator, which was already fixed by commits 9332ad3 and cee3c33. Add regression tests covering both single-project and multi-module builds with version inherited from a remote parent POM (different groupId, empty relativePath). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
rmannibucau
approved these changes
May 19, 2026
|
@gnodet Please assign appropriate label to PR according to the type of change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Invalid Collect Request: nullwhen building projects that inherit version from a remote parent POM with<relativePath/>CollectRequest.toString()(always shows null forgetRoot()since Maven usesgetRootArtifact()), not from a null root artifactTest plan
testVersionInheritedFromRemoteParent— single-project build inheriting version from remote parent with different groupIdtestVersionInheritedFromRemoteParentMultiModule— multi-module build with child inheriting version from remote parent🤖 Generated with Claude Code