Skip to content

Fix #12085: regression tests for version inheritance from remote parent #12090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gnodet merged 1 commit into from
May 19, 2026
Merged

Fix #12085: regression tests for version inheritance from remote parent #12090

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 39 additions & 0 deletions impl/maven-core/src/test/java/org/apache/maven/project/DefaultMavenProjectBuilderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -700,4 +700,43 @@ public void testEmptyModulesElementPreventsDiscovery() throws Exception {
// The modules list should be empty since we explicitly defined an empty <modules /> element
assertTrue(parent.getModel().getDelegate().getModules().isEmpty());
}

@Test
void testVersionInheritedFromRemoteParent() throws Exception {
File f1 = getTestFile("src/test/resources/projects/parent-version-inherited-from-remote/pom.xml");
MavenProject project = getProject(f1);

assertNotNull(project, "project should not be null");
assertEquals("1.0", project.getVersion(), "version should be inherited from remote parent");
assertNotNull(project.getArtifact(), "project artifact should not be null");
assertEquals("1.0", project.getArtifact().getVersion(), "artifact version should match inherited version");
assertEquals("org.different.group", project.getGroupId(), "groupId should be from child POM");
assertEquals("child-project", project.getArtifactId(), "artifactId should be from child POM");
}

@Test
void testVersionInheritedFromRemoteParentMultiModule() throws Exception {
File pom = getTestFile("src/test/resources/projects/parent-version-inherited-from-remote-multimodule/pom.xml");
ProjectBuildingRequest configuration = newBuildingRequest();
InternalSession internalSession = InternalSession.from(configuration.getRepositorySession());
InternalMavenSession mavenSession = InternalMavenSession.from(internalSession);
mavenSession
.getMavenSession()
.getRequest()
.setRootDirectory(pom.toPath().getParent());

List<ProjectBuildingResult> results = projectBuilder.build(List.of(pom), true, configuration);
assertEquals(2, results.size());

MavenProject child = results.stream()
.map(ProjectBuildingResult::getProject)
.filter(p -> "child-project".equals(p.getArtifactId()))
.findFirst()
.orElse(null);
assertNotNull(child, "child project should be found");
assertEquals("1.0", child.getVersion(), "version should be inherited from remote parent");
assertNotNull(child.getArtifact(), "child project artifact should not be null");
assertEquals("1.0", child.getArtifact().getVersion(), "artifact version should match inherited version");
assertEquals("org.different.group", child.getGroupId(), "groupId should be from child POM");
}
}
31 changes: 31 additions & 0 deletions impl/maven-core/src/test/remote-repo/org/test/parent-pom/1.0/parent-pom-1.0.pom
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
<project>
<modelVersion>4.0.0</modelVersion>
<groupId>org.test</groupId>
<artifactId>parent-pom</artifactId>
<version>1.0</version>
<packaging>pom</packaging>

<repositories>
<repository>
<id>staging</id>
<url>https://repository.example.org/staging</url>
</repository>
</repositories>

<profiles>
<profile>
<id>nightly</id>
<activation>
<property>
<name>nightly</name>
</property>
</activation>
<repositories>
<repository>
<id>${uninterpolatedRepoId}</id>
<url>file://${SNAPSHOTS_PATH}</url>
</repository>
</repositories>
</profile>
</profiles>
</project>
12 changes: 12 additions & 0 deletions ...rc/test/resources/projects/parent-version-inherited-from-remote-multimodule/child/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
<project>
<modelVersion>4.0.0</modelVersion>
<parent>
<groupId>org.test</groupId>
<artifactId>parent-pom</artifactId>
<version>1.0</version>
<relativePath/>
</parent>
<groupId>org.different.group</groupId>
<artifactId>child-project</artifactId>
<!-- no version - inherited from remote parent -->
</project>
10 changes: 10 additions & 0 deletions ...core/src/test/resources/projects/parent-version-inherited-from-remote-multimodule/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
<project>
<modelVersion>4.0.0</modelVersion>
<groupId>org.test.aggregator</groupId>
<artifactId>aggregator</artifactId>
<version>1.0</version>
<packaging>pom</packaging>
<modules>
<module>child</module>
</modules>
</project>
12 changes: 12 additions & 0 deletions impl/maven-core/src/test/resources/projects/parent-version-inherited-from-remote/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
<project>
<modelVersion>4.0.0</modelVersion>
<parent>
<groupId>org.test</groupId>
<artifactId>parent-pom</artifactId>
<version>1.0</version>
<relativePath/>
</parent>
<groupId>org.different.group</groupId>
<artifactId>child-project</artifactId>
<!-- no version - inherited from parent -->
</project>
Loading