Backport #12538: Handle Ctrl+C on Windows terminals - #12550
Merged
Conversation
On Windows, JLine handles Ctrl+C as the terminal's `INT` signal. Without an explicit handler, the standalone Maven JVM does not follow its normal interrupt termination path and Maven's shutdown hooks do not run, which can leave long-running child processes alive. This change registers an `INT` handler for Windows terminals that exits with status `130`. This triggers normal JVM shutdown and its registered cleanup hooks.
gnodet
commented
Jul 27, 2026
gnodet
left a comment
gnodet
left a comment
Contributor
Author
There was a problem hiding this comment.
✅ Clean and complete backport of #12538 to maven-4.0.x.
The cherry-pick faithfully reproduces the Ctrl+C signal handler fix with correct conflict resolution preserving the ProjectBuildLogAppender ordering specific to the maven-4.0.x branch.
Key observations:
- All three changes from the original PR are correctly applied: the
org.jline.utils.OSUtilsimport, theSIGINT_EXIT_CODE = 130constant, and theTerminal.Signal.INThandler guarded byOSUtils.IS_WINDOWS && !context.invokerRequest.embedded(). - The conflict resolution is correct — on
maven-4.0.x, theProjectBuildLogAppenderblock is positioned beforeMessageUtils.systemInstall(), whereas onmasterit comes after. The backport preserves themaven-4.0.xordering, which is the right approach since the ordering difference is pre-existing and unrelated to this fix. - The signal handler is self-contained and does not interact with the
ProjectBuildLogAppenderpositioning, so no functional difference arises from the ordering variance between branches.
This review was generated by an AI agent and may contain inaccuracies. Please verify all suggestions before applying.
Claude Code on behalf of gnodet
gnodet
added a commit
to gnodet/maven
that referenced
this pull request
Jul 27, 2026
|
@gnodet Please assign appropriate label to PR according to the type of change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #12538 to
maven-4.0.x.Cherry-pick of a3e576b with a minor conflict resolution to preserve the
ProjectBuildLogAppenderblock present on this branch.Original PR: #12538
Original issue: #12536
On Windows, JLine puts the terminal into raw mode and consumes Ctrl+C as console input before the JVM sees it. This registers a
Terminal.Signal.INThandler that callsSystem.exit(130)(128 + SIGINT) to restore proper Ctrl+C behavior, guarded byOSUtils.IS_WINDOWSand!embedded().