Skip to content

Deps: Bump to Eclipse Sisu 1.1.0 - #12552

Closed
cstamas wants to merge 1 commit into
apache:maven-4.0.xfrom
cstamas:maven-4.0.x-sisu110
Closed

Deps: Bump to Eclipse Sisu 1.1.0#12552
cstamas wants to merge 1 commit into
apache:maven-4.0.xfrom
cstamas:maven-4.0.x-sisu110

Conversation

@cstamas

@cstamas cstamas commented Jul 27, 2026

Copy link
Copy Markdown
Member

@cstamas cstamas self-assigned this Jul 27, 2026
@cstamas cstamas added the dependencies Pull requests that update a dependency file label Jul 27, 2026
@gnodet

gnodet commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

CI Failure Analysis

Same failure as #12551 — all 18 downstream checks (full-build + integration-tests) fail with:

[INFO] Resolving Mimir daemon version 0.12.0
[WARNING] Failed to resolve daemon: Unknown NameMapper name: 'file-gaecv', known ones: []
[ERROR] Error enabling Mimir: java.io.IOException: Mimir daemon JAR not found

initial-build passes (Maven 4.0.0-rc-5 wrapper uses Sisu 1.0.1). The downstream jobs run the newly-built Maven with Sisu 1.1.0, where the new JSR330 bean filtering (sisu-project#266) hides all NameMapper implementations from the Mimir extension realm (known ones: []).

See analysis on #12551 for details.

@gnodet

gnodet commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Update: TCCL + Realm Visibility Root Cause

Posted a detailed analysis on #12551 — the issue is the interaction between DefaultMaven.callListeners() setting TCCL to the extension realm (line 376), and Sisu 1.1.0's new FilteredBeans in DefaultBeanLocator.locate() using RealmManager.contextRealm() (which walks the TCCL) to determine visibility. Mimir's realm can't see plexus.core's NameMapper beans under the new filtering.

See #12551 comment for full details and fix directions.

@gnodet

gnodet commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Closing in favor of #12554 (master) and #12556 (4.0.x), which fix the root cause properly.

The original approach of just bumping Sisu to 1.1.0 exposed a realm visibility issue: extension realms (parent=plexus.core) couldn't see beans sourced from the maven.ext container realm through Sisu 1.1.0's new jsr330ComponentVisibilityFollowsPlexusVisibility filtering. The fix adds a reverse realm import (realm.importFrom(extRealm, extRealm.getId())) so that maven.ext is reachable in Sisu's visibility BFS traversal from extension realms — working with the filtering feature, not against it.

@gnodet gnodet closed this Jul 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants