[Backport 4.0.x] [MNG-8425] Fix mvnenc init saving invalid master source configuration - #12564
Merged
Merged
Conversation
gnodet
commented
Jul 28, 2026
gnodet
left a comment
gnodet
left a comment
Contributor
Author
There was a problem hiding this comment.
LGTM — clean backport of #12418 (merged on master today). The fix correctly handles mvnenc init prefix prepending for template-based configuration values (e.g., env:, system-property:), and the new InitTest provides solid parameterized coverage of the prefix logic.
This review was generated by an AI agent and may contain inaccuracies. Please verify all suggestions before applying.
Claude Code on behalf of gnodet
gnodet
added a commit
to gnodet/maven
that referenced
this pull request
Jul 28, 2026
|
@gnodet Please assign appropriate label to PR according to the type of change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #12418 to
maven-4.0.x.When the encryption wizard prompts for an editable value with a template like
env:$MVN_PASSWORD, the user input is now auto-prefixed with the source prefix (env:,system-property:, etc.) if missing. Adds parameterized test covering 5 prefix scenarios.Fixes MNG-8425 / #10202