[Backport 4.0.x] Fix #12427: Reject path-traversal segments in coordinate ids and versions - #12565
Merged
Merged
Conversation
…ions Coordinate ids (groupId, artifactId) and versions equal to '.' or '..' pass character validation but become path-traversal segments in the local repository layout. Both the maven-impl and compat maven-model-builder validators now reject these values in id checks, wildcard-id checks, and version checks. Tests added for both modules. Closes #12410
gnodet
commented
Jul 28, 2026
gnodet
left a comment
gnodet
left a comment
Contributor
Author
There was a problem hiding this comment.
LGTM — clean backport of #12410 (merged on master). The security fix correctly rejects . and .. as coordinate ids and versions to prevent path-traversal in the local repository layout. Both compat/maven-model-builder and impl/maven-impl validators are covered with well-structured tests (single-dot and double-dot cases). The isPathTraversalSegment() helper is clearly documented with Javadoc explaining why these values are rejected.
This review was generated by an AI agent and may contain inaccuracies. Please verify all suggestions before applying.
Claude Code on behalf of gnodet
gnodet
added a commit
to gnodet/maven
that referenced
this pull request
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #12410 to
maven-4.0.x.Coordinate ids (groupId, artifactId) and versions equal to
.or..pass character validation but become path-traversal segments in the local
repository layout. Both the
maven-impland compatmaven-model-buildervalidators now reject these values. Tests added for both modules.
Conflict resolution: trivial variable naming difference (
i/con 4.0.xvs
index/characteron master).