[Backport 4.0.x] Fix #12534: Wire up @After annotation processing in Maven core - #12566
Merged
Conversation
gnodet
commented
Jul 28, 2026
gnodet
left a comment
gnodet
left a comment
Contributor
Author
There was a problem hiding this comment.
LGTM — clean backport of #12535 (merged on master). Makes @After repeatable with @Afters container, defaults type() to PROJECT, and wires up annotation processing in BuildPlanExecutor. Comprehensive test coverage with unit tests and integration test (mng-12534-after-annotation). Conflict resolution (commented-out test block) is noted and clean.
This review was generated by an AI agent and may contain inaccuracies. Please verify all suggestions before applying.
Claude Code on behalf of gnodet
gnodet
added a commit
to gnodet/maven
that referenced
this pull request
Jul 28, 2026
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Adapt the IT to the 4.0.x AbstractMavenIntegrationTestCase API: - Add constructor with version range "[4.0.0-rc-6,)" - Use File instead of Path (extractResources returns File) - Use String basedir for newVerifier (not Path) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The test plugin referenced maven-api-core 4.1.0-SNAPSHOT (master version) but on the maven-4.0.x branch the API version is 4.0.0-SNAPSHOT, causing dependency resolution failure in CI. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
cstamas
approved these changes
Jul 28, 2026
rmannibucau
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #12535 to
maven-4.0.x.Makes
@Afterrepeatable (@Afterscontainer), defaultstype()toPROJECT, and wires up annotation processing inBuildPlanExecutorsothat mojos annotated with
@Aftercorrectly declare ordering constraints.Includes unit tests and integration test (
mng-12534-after-annotation).Conflict resolution: the
BuildPlanCreatorTesthad a commented-out testblock on 4.0.x (
/*) vs new test methods on master — kept both (newtests added before the existing commented block).