[4.0.x] Fix #11504: add replacement guidance to deprecated model and settings APIs - #12890
Merged
Conversation
… APIs (#12872) Update @deprecated Javadoc tags in maven.mdo and settings.mdo to tell users what to use instead of each deprecated element: - Notifier.address → use the configuration properties map - Model.getProjectDirectory() → use getProjectDirectoryPath() - ModelBase.reports → use the reporting element - ConfigurationContainer.unsetInheritanceApplied() → no-op, no replacement - ConfigurationContainer.setInherited(boolean) → use setInherited(String) - Plugin.goals → use executions - Plugin.flushExecutionMap() → no-op, no replacement - Reporting.flushReportPluginMap() → no-op, no replacement - Settings.getMirrorOf() → use mirror matching infrastructure Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
gnodet
commented
Aug 28, 2026
gnodet
left a comment
gnodet
left a comment
Contributor
Author
There was a problem hiding this comment.
Clean backport of #12872 to maven-4.0.x. The diff is byte-identical to the original — only hunk offsets differ due to branch divergence. All 9 deprecated elements receive accurate replacement guidance:
getProjectDirectory()→getProjectDirectoryPath()reports→reportingNotifier.address→configurationmapunsetInheritanceApplied(),flushExecutionMap(),flushReportPluginMap()→ correctly marked as no-op with no replacementsetInherited(boolean)→setInherited(String)Plugin.goals→executionsSettings.getMirrorOf(String)→ explains limitation and directs to Maven mirror matching infrastructure
✅ LGTM — documentation-only, no behavioral impact.
This review was generated by an AI agent and may contain inaccuracies. Please verify all suggestions before applying.
Claude Code on behalf of Guillaume Nodet
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #12872 to
maven-4.0.x.Summary
@deprecatedJavadoc tags with replacement guidance to 9 deprecated elements acrossmaven.mdoandsettings.mdothat were missing "what to use instead" informationorg.apache.maven.api.model) and the compat model (org.apache.maven.model) as well asorg.apache.maven.settingsTest plan
maven-4.0.x