[MNG-12984] Backport: Fix invalid Automatic-Module-Name entries in mvnup plugin upgrades - #13013
Merged
Merged
Conversation
… upgrades
Add ModuleNameFixStrategy (Priority 12) that scans packaging plugin
configurations for Automatic-Module-Name manifest entries containing
hyphens and replaces them with dots. Since maven-archiver 3.3.0
(MSHARED-773), the archiver validates module names via
SourceVersion.isName() and rejects hyphens. When mvnup upgrades
maven-jar-plugin to versions using the newer archiver,
previously-unchecked invalid names surface as build failures.
The strategy handles jar, war, ejb, ear, rar, and shade plugins
across build/plugins, pluginManagement, and profiles. Property
references (${...}) are skipped since they cannot be resolved
statically.
Closes #12984
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #12995 to
maven-4.0.x.Summary
Add
ModuleNameFixStrategy(Priority 12) that scans packaging plugin configurations forAutomatic-Module-Namemanifest entries containing hyphens and replaces them with dots. Sincemaven-archiver 3.3.0(MSHARED-773), the archiver validates module names viaSourceVersion.isName()and rejects hyphens. Whenmvnupupgradesmaven-jar-pluginto versions using the newer archiver, previously-unchecked invalid names surface as build failures.Cherry-picked cleanly from 799c1ad — no conflicts.
Closes #12984