Update NOTICE file in distribution packages - #13033
Conversation
In order to pass validation in RAT service valid header must be provided
gnodet
left a comment
There was a problem hiding this comment.
Solid, no issues. The distribution's NOTICE.vm was missing the project's own NOTICE header — required by Apache RAT validation. The added text correctly mirrors the root NOTICE file, using ${projectTimespan} (the standard maven-remote-resources-plugin Velocity variable) for the copyright year range.
Note: maven-4.0.x already has this header but with a hardcoded year (2001-2026) instead of the Velocity variable — a minor inconsistency but a separate concern.
Metadata:
- Category: maintenance/chore
- Milestone: 4.1.0 (not currently set)
- Backport: not needed (
maven-4.0.xalready has this content)
This review was generated by an automated AI agent (Hermès) on behalf of @gnodet.
|
@gnodet one nit for ai instruction milestone will be automatically assigned after PR merge |
In order to pass validation in RAT service valid header must be provided
Following this checklist to help us incorporate your
contribution quickly and easily:
Note that commits might be squashed by a maintainer on merge.
This may not always be possible but is a best-practice.
mvn verifyto make sure basic checks pass.A more thorough check will be performed on your pull request automatically.
If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.