Skip to content

Update NOTICE file in distribution packages - #13033

Merged
slawekjaranowski merged 1 commit into
apache:masterfrom
slawekjaranowski:notice
Sep 4, 2026
Merged

Update NOTICE file in distribution packages#13033
slawekjaranowski merged 1 commit into
apache:masterfrom
slawekjaranowski:notice

Conversation

@slawekjaranowski

Copy link
Copy Markdown
Member

In order to pass validation in RAT service valid header must be provided


Following this checklist to help us incorporate your
contribution quickly and easily:

  • Your pull request should address just one issue, without pulling in other changes.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body.
    Note that commits might be squashed by a maintainer on merge.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
    This may not always be possible but is a best-practice.
  • Run mvn verify to make sure basic checks pass.
    A more thorough check will be performed on your pull request automatically.
  • You have run the Core IT successfully.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

In order to pass validation in RAT service valid header must be provided

@gnodet gnodet left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid, no issues. The distribution's NOTICE.vm was missing the project's own NOTICE header — required by Apache RAT validation. The added text correctly mirrors the root NOTICE file, using ${projectTimespan} (the standard maven-remote-resources-plugin Velocity variable) for the copyright year range.

Note: maven-4.0.x already has this header but with a hardcoded year (2001-2026) instead of the Velocity variable — a minor inconsistency but a separate concern.

Metadata:

  • Category: maintenance/chore
  • Milestone: 4.1.0 (not currently set)
  • Backport: not needed (maven-4.0.x already has this content)

This review was generated by an automated AI agent (Hermès) on behalf of @gnodet.

@slawekjaranowski

Copy link
Copy Markdown
Member Author

@gnodet one nit for ai instruction

milestone will be automatically assigned after PR merge
will be chosen milestone with description branch: <target-branch-name>,
in this case https://github.com/apache/maven/milestone/25

@slawekjaranowski
slawekjaranowski merged commit db62719 into apache:master Sep 4, 2026
41 of 42 checks passed
@slawekjaranowski
slawekjaranowski deleted the notice branch September 4, 2026 08:17
@github-actions github-actions Bot added this to the 4.1.0 milestone Sep 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants