Documented EOF in ATTACH_CONTAINER_INPUT

[bamarni]

This documents how to indicate when EOF is reached on STDIN.

See https://github.com/dcos/dcos-core-cli/blob/009999e1d8f4eddca5d961152f32669e02ed81d5/python/lib/dcos/dcos/mesos.py#L1657-L1658

[jdef]

@vinodkone PTAL

[vinodkone]

LGTM. Should we add the extra bit about the expectation when TTY is enabled? See comment here: https://github.com/apache/mesos/blob/master/src/slave/containerizer/mesos/io/switchboard.cpp#L1727

[jdef]

Yes, I think this makes sense to include.

…

On Tue, Jul 2, 2019 at 2:32 PM Vinod Kone ***@***.***> wrote: ***@***.**** commented on this pull request. LGTM. Should we add the extra bit about the expectation when TTY is enabled? See comment here: https://github.com/apache/mesos/blob/master/src/slave/containerizer/mesos/io/switchboard.cpp#L1727 — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#340?email_source=notifications&email_token=AAR5KLCWPPLENB32KV7KPSTP5ONNVA5CNFSM4H426542YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB5JKNXQ#pullrequestreview-257074910>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAR5KLCXS5QC7MHPSD6YDZDP5ONNVANCNFSM4H42654Q> .

-- James DeFelice 585.241.9488 (voice) 650.649.6071 (fax)

[bamarni]

Updated it, I've used launched with an associated IOSwitchboard instead of tty as it's what's being used elsewhere on the page.

[jdef]

@vinodkone PTAL, feedback has been addressed

[vinodkone]

IOSwitchboard is used by containers with or without TTY.

s/launched with an associated IOSwitchboard/launched with TTYInfo in their ContainerInfo/

[bamarni]

@vinodkone : is this sentence a few lines above accurate then?

This call can only be made against containers that have been launched with an associated IOSwitchboard (i.e. nested containers launched via a LAUNCH_NESTED_CONTAINER_SESSION call or normal containers launched with a TTYInfo in their ContainerInfo)

See also https://github.com/dcos/dcos-core-cli/blob/1.14-patch.x/python/lib/dcos/dcos/mesos.py#L1425-L1428, where the code treats a missing I/O Switchboard as missing TTY.

[vinodkone]

@bamarni For a regular container launched by a framework, IOSwitchboard is only enabled when TTY is requested. But an operator can launch a debug container without TTY and IOSwitchboard is still enabled AFAIK. In other words, TTY => IOSwitchboard but not the other way around. @abudnik @Gilbert88 can you confirm?

[abudnik]

@bamarni For a regular container launched by a framework, IOSwitchboard is only enabled when TTY is requested. But an operator can launch a debug container without TTY and IOSwitchboard is still enabled AFAIK. In other words, TTY => IOSwitchboard but not the other way around. @abudnik @Gilbert88 can you confirm?

Yes, correct.
Also, a debug container can be launched only by LAUNCH_NESTED_CONTAINER_SESSION call.

[bamarni]

Thanks for the clarification @abudnik @vinodkone , I've updated the PR