Skip to content

Comments

Mention that tests should be run as root/admin in contribution guides.#358

Closed
cf-natali wants to merge 1 commit intoapache:masterfrom
cf-natali:charles-doc-make-check-root
Closed

Mention that tests should be run as root/admin in contribution guides.#358
cf-natali wants to merge 1 commit intoapache:masterfrom
cf-natali:charles-doc-make-check-root

Conversation

@cf-natali
Copy link
Contributor

@bmahler
Copy link
Contributor

bmahler commented Apr 16, 2020

@abudnik perhaps we could be a bit more specific about when to run as root?

We have a lot of test filters so it's a little more generalized (e.g. if you're touching a 'curl' related test make sure that runs, if touching a docker related test make sure that runs, etc): https://github.com/apache/mesos/blob/master/src/tests/environment.cpp

I'm not sure we'll be able to write a good guideline here, other than just generally explaining how tests can be filtered for various reasons and then relying on contributors / reviewers / CI to make sure the appropriate ones are run.

@cf-natali cf-natali closed this Jan 30, 2021
@cf-natali cf-natali deleted the charles-doc-make-check-root branch January 30, 2021 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants