Mention that tests should be run as root/admin in contribution guides.#358
Closed
cf-natali wants to merge 1 commit intoapache:masterfrom
Closed
Mention that tests should be run as root/admin in contribution guides.#358cf-natali wants to merge 1 commit intoapache:masterfrom
cf-natali wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
|
@abudnik perhaps we could be a bit more specific about when to run as root? We have a lot of test filters so it's a little more generalized (e.g. if you're touching a 'curl' related test make sure that runs, if touching a docker related test make sure that runs, etc): https://github.com/apache/mesos/blob/master/src/tests/environment.cpp I'm not sure we'll be able to write a good guideline here, other than just generally explaining how tests can be filtered for various reasons and then relying on contributors / reviewers / CI to make sure the appropriate ones are run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@abudnik