Expose hierarchical allocator recovery parameters as master flags#367
Expose hierarchical allocator recovery parameters as master flags#367Lqp1 wants to merge 3 commits intoapache:masterfrom
Conversation
asekretenko
left a comment
asekretenko
left a comment
There was a problem hiding this comment.
Thanks for addressing this TODO; might be useful to other users running large clusters.
Overall looks good; there is a number of minor issues to be addressed before merging this (see below).
|
|
||
| #include <mesos/quota/quota.hpp> | ||
|
|
||
| #include <master/constants.hpp> |
There was a problem hiding this comment.
The definitions in the public allocator interface must not depend on the internal ones.
I.e. the headers in include/ should be usable without ones from src/.
Is it possible to define these constants here, either in this header or in a some other header (in the worst case, in a new one)?
There was a problem hiding this comment.
So the flags defined for master will depend on include/allocator/allocator.hpp header (instead of the more generic constants.hpp? Is that ok?
* use double instead of float * renamed vars and const * removed unnecessary attributes in hierarchical allocator
asekretenko
left a comment
asekretenko
left a comment
There was a problem hiding this comment.
Thanks!
Looks good.
I'll merge this, looks like my recent additions to options cause a conflict.
|
Thanks! |
2 participants
Hello,
We needed to expose two parameters of the hierarchical allocator recovery options as master flags. Are you interested in such a PR?
We needed to tweak those values, and rebuilding mesos + deploy it again each time was not very time saving. These flags can be used to have per DC parameters also.
It's rather simple but if you have any input on how I can improve it, don't hesitate.
Br