Add mesos authentication to the mesos cli by andreaspeters · Pull Request #383 · apache/mesos

andreaspeters · 2021-05-02T10:25:15Z

The following points I done:

Add authentication against mesos manager and agent
Add option to skip SSL verification of the mesos-agent
Changed the order of "task list" to get back more running states

asekretenko

The approach looks good overall; thanks for addressing this!

src/python/cli_new/lib/cli/config.py

src/python/cli_new/lib/cli/http.py

src/python/cli_new/lib/cli/mesos.py

andreaspeters · 2021-05-02T17:17:34Z

Does we have a list of features we want to see in the mesos_cli? I'm also planning to develope a plugin for our kubernetes framework.

andreaspeters · 2021-05-03T07:12:26Z

@asekretenko I'm done now. U can review again. :-)

src/python/cli_new/lib/cli/config.py

src/python/cli_new/lib/cli/http.py

src/python/cli_new/lib/cli/mesos.py

kamaradclimber · 2021-05-24T13:42:02Z

Could you squash all commits to increase readability of this history before merging?

andreaspeters · 2021-05-24T14:54:38Z

Could you squash all commits to increase readability of this history before merging?

Done :-)

kamaradclimber · 2021-05-24T15:22:11Z

Are you sure? I still see 17 commits.

andreaspeters · 2021-05-25T07:00:53Z

Are you sure? I still see 17 commits.

🤔 not 100%! But like u see, the last commit include all changes. 🤷‍♂️

andreaspeters · 2021-05-25T09:23:57Z

Are you sure? I still see 17 commits.

thinking not 100%! But like u see, the last commit include all changes. man_shrugging

Yeah it looks like I done something wrong during my past commits that the squash didn't worked as I expected. Can u squash during the MR?

cf-natali · 2021-05-25T17:21:39Z

Are you sure? I still see 17 commits.

thinking not 100%! But like u see, the last commit include all changes. man_shrugging

Yeah it looks like I done something wrong during my past commits that the squash didn't worked as I expected. Can u squash during the MR?

Maybe, but it'll be easier using git rebase. Then just need to git push -f

andreaspeters · 2021-05-25T19:19:25Z

Are you sure? I still see 17 commits.

thinking not 100%! But like u see, the last commit include all changes. man_shrugging

Yeah it looks like I done something wrong during my past commits that the squash didn't worked as I expected. Can u squash during the MR?

Maybe, but it'll be easier using git rebase. Then just need to git push -f

Hopefully I didn't broke more as I fixed with the rebase. 😅

src/python/cli_new/lib/cli/config.py

src/python/cli_new/lib/cli/http.py

src/python/cli_new/lib/cli/config.py

src/python/cli_new/lib/cli/http.py

src/python/cli_new/lib/cli/mesos.py

src/python/cli_new/lib/cli/plugins/task/main.py

author Andreas Peters <ap@aventer.biz> 1619948566 +0200 committer Andreas Peters <ap@aventer.biz> 1621969642 +0200 gpgsig -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEGTSo9iZLKmYD5nQgaoPxJUHPzPkFAmCtSuoACgkQaoPxJUHP zPmV7Qf+KuOPleQh/tEGVuMoA80PcvMQNTay5hcBbKyFlPhpPklyjzAIKo4F01GQ 3yXthlKCdZqJrw4b0nTxDogCTJyP3U6s9p437AonkEfvVRDCNNzgEmDduC1wBfJ9 Whbs2C04Ceg9B08BwdPkmaJc8dvHDqEo+EPpQJw4/dFD8j2xF14EiJJxiDbrH+Bb aTkX8sSAGVuNmNSU/z0VM/AXtfnixD8b8cf1Q6YsN5XK72Qc0h7ElsfYkwPmCzY2 ut+zTPi2l1HEbMB/zJkHhF7ec4MrMZcWc5EjCLx/9IJNOXlz3pzTeF2Fz0xCTMlR NpaaOV2fJzDqTC13VPomDumxgdQ2uQ== =TpxP -----END PGP SIGNATURE----- change task order to show all running tasks first check authentication parameters update tests and fix pylint add agent authentication and add option to skip ssl verification add checks to read configuration parmeters move the basic auth authentication into a single function fix linting capture unknonw data encode errors remove unnecessery loop int and cleanup add missing auth and verify change parts to be more readable remove not usefull exception handling add checks to read configuration parmeters move the basic auth authentication into a single function fix linting add missing auth and verify change parts to be more readable remove not usefull exception handling change agent parameter handling ADD timeout parameter to config and change error execption. ADD default values to prototype.

ridv · 2021-06-01T17:54:57Z

Could you squash all commits to increase readability of this history before merging?

In the past the commiter merging the change used the "squash and merge" strategy which has the same effect. So no need to do anything special 😄 . (In fact, it's probably better to leave the individual commits to see how the patch progressed which is a bit of a carry over from when reviews happened on Review Board)

src/python/cli_new/lib/cli/config.py

src/python/cli_new/lib/cli/plugins/task/main.py

cf-natali · 2021-06-06T09:31:06Z

@asekretenko @qianzhangxa
Maybe you could have a look at it?

andreaspeters · 2021-06-09T10:46:56Z

@asekretenko @qianzhangxa
Maybe you could have a look at it?

Some feedback? :-)

qianzhangxa · 2021-06-09T13:13:10Z

I am not very familiar with Python :(
@asekretenko can you please review again?

src/python/cli_new/lib/cli/http.py

asekretenko · 2021-07-01T18:53:22Z

Other than this question about the condition logic, I don't see any other issues.

andreaspeters · 2021-07-18T08:51:27Z

Can we merge it please?

cf-natali · 2021-07-20T21:09:01Z

Yeah this PR has been open for a while now, and @andreaspeters has addressed all the comments.
I reviewed it and it looks good to me, although I don't use Python with Mesos at all.

qianzhangxa · 2021-07-21T13:10:09Z

Sorry for the late response, I have merged it, thanks for the contributions @andreaspeters!

andreaspeters · 2021-07-21T13:13:37Z

No problem @qianzhangxa. Your welcome. :-)

add mesos authentication

f5f3563

asekretenko reviewed May 2, 2021

View reviewed changes

andreaspeters requested a review from asekretenko May 7, 2021 21:05

cf-natali reviewed May 13, 2021

View reviewed changes

cf-natali reviewed May 26, 2021

View reviewed changes

src/python/cli_new/lib/cli/config.py Outdated Show resolved Hide resolved

cf-natali reviewed May 26, 2021

View reviewed changes

src/python/cli_new/lib/cli/http.py Show resolved Hide resolved

cf-natali reviewed May 26, 2021

View reviewed changes

src/python/cli_new/lib/cli/http.py Outdated Show resolved Hide resolved

cf-natali reviewed May 31, 2021

View reviewed changes

cf-natali reviewed Jun 2, 2021

View reviewed changes

src/python/cli_new/lib/cli/config.py Show resolved Hide resolved

cf-natali reviewed Jun 2, 2021

View reviewed changes

src/python/cli_new/lib/cli/config.py Show resolved Hide resolved

cf-natali reviewed Jun 2, 2021

View reviewed changes

src/python/cli_new/lib/cli/config.py Show resolved Hide resolved

cf-natali reviewed Jun 2, 2021

View reviewed changes

src/python/cli_new/lib/cli/plugins/task/main.py Show resolved Hide resolved

cf-natali approved these changes Jun 2, 2021

View reviewed changes

asekretenko reviewed Jul 1, 2021

View reviewed changes

src/python/cli_new/lib/cli/http.py Show resolved Hide resolved

asfgit closed this in c66aaf4 Jul 21, 2021

Conversation

andreaspeters commented May 2, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

asekretenko left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

andreaspeters commented May 2, 2021

Uh oh!

andreaspeters commented May 3, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kamaradclimber commented May 24, 2021

Uh oh!

andreaspeters commented May 24, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kamaradclimber commented May 24, 2021

Uh oh!

andreaspeters commented May 25, 2021

Uh oh!

andreaspeters commented May 25, 2021

Uh oh!

cf-natali commented May 25, 2021

Uh oh!

andreaspeters commented May 25, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ridv commented Jun 1, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cf-natali commented Jun 6, 2021

Uh oh!

andreaspeters commented Jun 9, 2021

Uh oh!

qianzhangxa commented Jun 9, 2021

Uh oh!

Uh oh!

asekretenko commented Jul 1, 2021

Uh oh!

andreaspeters commented Jul 18, 2021

Uh oh!

cf-natali commented Jul 20, 2021

Uh oh!

qianzhangxa commented Jul 21, 2021

Uh oh!

andreaspeters commented Jul 21, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

andreaspeters commented May 2, 2021 •

edited

Loading

andreaspeters commented May 24, 2021 •

edited

Loading