Add Allegro to the list of adopters #43
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're using marathon on top of the mesos 0.22.0
Member
|
Thanks for this contribution, I just pushed this to master. Could you please close this PR? |
Contributor
Author
|
Thanks :) Closed |
asfgit
pushed a commit
that referenced
this pull request
Sep 11, 2015
To get Stout tests to compile on Windows, it is necessary to upgrade the glog dependency to 0.3.4 (which will allow you to compile with MSVC 1800), and then port glog 0.3.4 to support compiling with MSVC 1900 (which Mesos requires). The code comments explain why we can't compile with 1800 and link simply have Mesos link to it. Note that we have supplied the MSVC 1900 port to the glog project, under pull request #43[1]. The longer story follows: glog v0.3.3 will not build on Windows for a few reasons that are fixed in the 0.3.4 release. (For example, `algorithms` is not included in one file the requires it.) Since 0.3.4 appears to only fix bugs, and because there appear to be no major changes in (e.g.) the ABI, I believe this is a safe change to make. Additionally, when we ported it to compile on MSVC 1900, we didn't want to re-write the changes they made in 0.3.4 to make it run on MSVC 1800, so this was a natural starting point for us. I choose not to attempt to upgrade the Linux glog dependency, either in the CMake solution, or in the autotools solution, for 3 reasons. (1) I don't want to ask the community reconsider its dependency choices on the basis that an experimental Windows port requires a more recent version. (2) We are currently rebundling the glog library as a binary, which means that a solution will be somewhat involved (i.e., either we have to change the patch command we're running on glog, or we have to change the binary) (3) We can easily support both versions in CMake using the very powerful macro system, which will allow us download the dependency on Windows machines and use the tarball on other systems. Footnotes: [1] google/glog#43 Review: https://reviews.apache.org/r/37020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're using marathon on top of the mesos 0.22.0