[cgroups2] Introduce cgroups2::disable to disable a controller.#536
Closed
DevinLeamy wants to merge 1 commit intoapache:masterfrom
Closed
[cgroups2] Introduce cgroups2::disable to disable a controller.#536DevinLeamy wants to merge 1 commit intoapache:masterfrom
DevinLeamy wants to merge 1 commit intoapache:masterfrom
Conversation
Allows a controller to be disabled on a cgroup. A test is introduced. We additionally move the read and write utilities so that they are accessible when we read the cgroup.subtree_control control file.
DevinLeamy
force-pushed
the
disable-controller
branch
from
7f7308b to
9c4a829
Compare
bmahler
reviewed
Mar 26, 2024
|
|
||
| TEST_F(Cgroups2Test, ROOT_CGROUPS2_EnableAndDisable) | ||
| { | ||
| ASSERT_SOME(cgroups2::create(TEST_CGROUP)); |
Contributor
There was a problem hiding this comment.
we want to call enable_controllers here to ensure the root cgroup has the cpu controller enabled, right?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows a controller to be disabled on a cgroup. A test is introduced.
We additionally move the read and write utilities so that they are accessible when we read the cgroup.subtree_control control file.