Add support for docker network options#583
Merged
bmahler merged 1 commit intoapache:masterfrom May 29, 2024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short:
With these PR I want to add support for custom docker networks created by
docker network ...Long:
The Mesos DockerInfo Network object only supports four network modes: BRIDGE, HOST, USER, and NONE. If we want to use a network created by the Docker command docker network create ..., we cannot use the network mode. In that case, we have to add the DockerInfo parameter. The problem is, if we do not add a DockerInfo network mode, then the Docker executor will add a default one (Lines 839, 841). This means the Docker executor will try to run the container with two network parameters. Newer Docker engines do not accept this. To address this, my idea is to only add a default network mode if DockerInfo has no network and also no network parameter.