This repository was archived by the owner on Nov 17, 2023. It is now read-only.
Correct init idx2name on mult-CPU/GPU training#2337
Merged
piiswrong merged 1 commit intoapache:masterfrom Jun 4, 2016
Merged
Conversation
In Module.init_optimizer, idx2name has duplicated items when multiple contexts are provided. But _update_params_on_kvstore will be used in this case, and the duplication of items will cause wrong indexing in Optimizer._get_lr and Optimizer._get_wd.
Contributor
|
LGTM. Thanks |
Answeror
added a commit
to Answeror/mxnet
that referenced
this pull request
Jun 7, 2016
This patch is related to apache#2327 and apache#2337, which fix a bug of idx2name in multi-GPU environment for Module. Note, all previous codes which involved lr_mult and wd_mult in multi-GPU environment may suffer from this bug, for example, finetuning with lr_mult of lower layers fixed to zero on multi-GPU will give incorrect result.
tqchen
pushed a commit
that referenced
this pull request
Jun 8, 2016
* Correct init idx2name on multi-CPU/GPU training v2 This patch is related to #2327 and #2337, which fix a bug of idx2name in multi-GPU environment for Module. Note, all previous codes which involved lr_mult and wd_mult in multi-GPU environment may suffer from this bug, for example, finetuning with lr_mult of lower layers fixed to zero on multi-GPU will give incorrect result. * Refine ResNet example
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
Module.init_optimizer, idx2name has duplicated items when multiple contexts are provided.But
_update_params_on_kvstorewill be used in this case, and the duplication of items will cause wrong indexing inOptimizer._get_lrandOptimizer._get_wd.